Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation strings for share button labels #1851

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add translation strings for share button labels #1851

wants to merge 3 commits into from

Conversation

JacobArrow
Copy link
Contributor

@JacobArrow JacobArrow commented Dec 10, 2024 •
edited by kasperbirch1
Loading

@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons-translations branch from 4846d19 to ab19321 Compare December 10, 2024 15:19
@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons-translations branch from 0cdcb15 to 428fdd0 Compare December 11, 2024 15:40
@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons-translations branch from 428fdd0 to d12461e Compare December 11, 2024 15:55
@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons-translations branch from d12461e to 372a79c Compare December 12, 2024 09:40
@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons-translations branch from 372a79c to 78a91d1 Compare December 12, 2024 09:45
@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons-translations branch from 78a91d1 to 1343d19 Compare December 12, 2024 10:26
@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons-translations branch from 1343d19 to da85a54 Compare December 12, 2024 10:30
@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons-translations branch from da85a54 to 55a4dc4 Compare December 12, 2024 15:35
Adamik10
Adamik10 requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Adamik10 Adamik10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got something that should be changed :))

composer.json Show resolved Hide resolved
web/modules/custom/dpl_react_apps/src/Controller/DplReactAppsController.php Show resolved Hide resolved
@JacobArrow JacobArrow force-pushed the KBHBIB-24-share-buttons-translations branch from 55a4dc4 to 713acf0 Compare January 20, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adamik10 Adamik10 Adamik10 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JacobArrow @Adamik10 @kasperg @kasperbirch1 @dpl-platform-bot